Re: [Mesa-dev] [PATCH mesa 08/16] amd/addrlib: fix DEBUG guards

2017-11-24 Thread Emil Velikov
On 24 November 2017 at 18:24, Marek Olšák wrote: > I'd like to keep the code as-is, because addrlib is an external project. > > However, since you Cc'd addrlib developers, they can apply the changes > to addrlib (if they want) and we can get the changes when we update > addrlib in Mesa. > Adding s

Re: [Mesa-dev] [PATCH mesa 08/16] amd/addrlib: fix DEBUG guards

2017-11-24 Thread Marek Olšák
I'd like to keep the code as-is, because addrlib is an external project. However, since you Cc'd addrlib developers, they can apply the changes to addrlib (if they want) and we can get the changes when we update addrlib in Mesa. Marek On Fri, Nov 24, 2017 at 7:07 PM, Eric Engestrom wrote: > Use

[Mesa-dev] [PATCH mesa 08/16] amd/addrlib: fix DEBUG guards

2017-11-24 Thread Eric Engestrom
Use the normal `#ifdef` style used by the rest of Mesa, instead of sometimes locally defining DEBUG on non-debug builds and then relying on the precompiler converting #undef'ed macros to 0 when checking. Signed-off-by: Eric Engestrom --- I would argue this block should go, as all it does is enabl