Re: [Mesa-dev] [PATCH mesa 04/16] amd: remove always-true BRAHMA_BUILD define

2017-11-28 Thread Marek Olšák
Internal addrlib doesn't contain BRAHMA_BUILD, so removing that definition is safe. The assert change is also OK. We'll just discard any new addrlib code that might replace it, because standard C assert is the only think we need. Marek On Tue, Nov 28, 2017 at 12:03 PM, Eric Engestrom wrote: > O

Re: [Mesa-dev] [PATCH mesa 04/16] amd: remove always-true BRAHMA_BUILD define

2017-11-28 Thread Eric Engestrom
On Friday, 2017-11-24 19:20:12 +0100, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Fri, Nov 24, 2017 at 7:07 PM, Eric Engestrom > wrote: > > Signed-off-by: Eric Engestrom > > --- > > src/amd/Android.addrlib.mk | 2 -- > > src/amd/Makefile.addrlib.am

Re: [Mesa-dev] [PATCH mesa 04/16] amd: remove always-true BRAHMA_BUILD define

2017-11-24 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Nov 24, 2017 at 7:07 PM, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/amd/Android.addrlib.mk | 2 -- > src/amd/Makefile.addrlib.am | 3 +-- > src/amd/addrlib/core/addrcommon.h| 15 ++-

[Mesa-dev] [PATCH mesa 04/16] amd: remove always-true BRAHMA_BUILD define

2017-11-24 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/amd/Android.addrlib.mk | 2 -- src/amd/Makefile.addrlib.am | 3 +-- src/amd/addrlib/core/addrcommon.h| 15 ++- src/amd/addrlib/meson.build | 2 +- src/gallium/winsys/amdgpu/drm/Android.mk | 4 +--