Re: [Mesa-dev] [PATCH mesa] meson: merge C and C++ compiler arguments check

2018-03-22 Thread Eric Engestrom
On Thursday, 2018-03-22 11:17:55 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-03-22 05:08:55) > > On Monday, 2018-03-12 10:16:33 -0700, Dylan Baker wrote: > > > Quoting Emil Velikov (2018-03-12 09:09:50) > > > > On 12 March 2018 at 15:01, Eric Engestrom > > > > wrote: > > > > > Signed

Re: [Mesa-dev] [PATCH mesa] meson: merge C and C++ compiler arguments check

2018-03-22 Thread Dylan Baker
Quoting Eric Engestrom (2018-03-22 05:08:55) > On Monday, 2018-03-12 10:16:33 -0700, Dylan Baker wrote: > > Quoting Emil Velikov (2018-03-12 09:09:50) > > > On 12 March 2018 at 15:01, Eric Engestrom > > > wrote: > > > > Signed-off-by: Eric Engestrom > > > > --- > > > > Dylan, was there any reaso

Re: [Mesa-dev] [PATCH mesa] meson: merge C and C++ compiler arguments check

2018-03-22 Thread Eric Engestrom
On Monday, 2018-03-12 10:16:33 -0700, Dylan Baker wrote: > Quoting Emil Velikov (2018-03-12 09:09:50) > > On 12 March 2018 at 15:01, Eric Engestrom wrote: > > > Signed-off-by: Eric Engestrom > > > --- > > > Dylan, was there any reason to have -Werror=missing-prototypes and > > > -Werror=implicit-

Re: [Mesa-dev] [PATCH mesa] meson: merge C and C++ compiler arguments check

2018-03-12 Thread Dylan Baker
Quoting Emil Velikov (2018-03-12 09:09:50) > On 12 March 2018 at 15:01, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > > --- > > Dylan, was there any reason to have -Werror=missing-prototypes and > > -Werror=implicit-function-declaration in C but not C++? > > Both sound to me like some

Re: [Mesa-dev] [PATCH mesa] meson: merge C and C++ compiler arguments check

2018-03-12 Thread Emil Velikov
On 12 March 2018 at 15:01, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > Dylan, was there any reason to have -Werror=missing-prototypes and > -Werror=implicit-function-declaration in C but not C++? > Both sound to me like something we always want. Seems to be copied from the auto

[Mesa-dev] [PATCH mesa] meson: merge C and C++ compiler arguments check

2018-03-12 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- Dylan, was there any reason to have -Werror=missing-prototypes and -Werror=implicit-function-declaration in C but not C++? Both sound to me like something we always want. --- meson.build | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) di