On Tuesday, 2018-11-06 14:32:53 +, Emil Velikov wrote:
> On Wed, 31 Oct 2018 at 18:47, Emil Velikov wrote:
>
> > > One that I'd like to eventually enable (and as an error if possible)
> > > is -Wundef to warn when undefined macros are used; in my experience at
> > > $PREVIOUS_JOB this warning
On Wed, 31 Oct 2018 at 18:47, Emil Velikov wrote:
> > One that I'd like to eventually enable (and as an error if possible)
> > is -Wundef to warn when undefined macros are used; in my experience at
> > $PREVIOUS_JOB this warning very often indicates actual bugs.
> >
> It would have caught a bug i
On Wed, 31 Oct 2018 at 18:20, Eric Engestrom wrote:
>
> On Wednesday, 2018-10-31 10:15:40 -0700, Dylan Baker wrote:
> > gtest doesn't generate any warnings, but this seems fine,
>
> It does for me, because I have more warnings enabled locally :P
>
Nothing special enabled here, gtest is fairly unha
On Wednesday, 2018-10-31 10:15:40 -0700, Dylan Baker wrote:
> gtest doesn't generate any warnings, but this seems fine,
It does for me, because I have more warnings enabled locally :P
One that I'd like to eventually enable (and as an error if possible)
is -Wundef to warn when undefined macros are
gtest doesn't generate any warnings, but this seems fine,
Reviewed-by: Dylan Baker
Quoting Eric Engestrom (2018-10-31 09:43:03)
> gtest is an external project that is copied in this tree for technical
> reasons, but isn't maintained by us, so its warnings are irrelevant.
>
> Cc: Emil Velikov
>
gtest is an external project that is copied in this tree for technical
reasons, but isn't maintained by us, so its warnings are irrelevant.
Cc: Emil Velikov
Signed-off-by: Eric Engestrom
---
src/gtest/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gtest/meson.build b/src/gt
