Re: [Mesa-dev] [PATCH mesa] meson: fix keyword argument in declare_dependency()

2017-12-06 Thread Dylan Baker
oops! Okay, I'm thinking I'm going to write a linter for meson to help catch these kind of mistakes because this isn't the first time that I've failed to catch these kind of errors in code that I don't build locally. Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-12-06 05:31:00) > `declar

[Mesa-dev] [PATCH mesa] meson: fix keyword argument in declare_dependency()

2017-12-06 Thread Eric Engestrom
`declare_dependency()` takes `compile_args`, not `c_args`. It was correct in all the other `declare_dependency()` from that commit. Fixes: 0bbecc5a8548883f76a71 "meson: define driver dependencies" Cc: Dylan Baker Signed-off-by: Eric Engestrom --- src/gallium/winsys/imx/drm/meson.build | 2 +-