Re: [Mesa-dev] [PATCH mesa] git_sha1_gen: fix output on python3

2017-08-02 Thread Jose Fonseca
Either way Reviewed-by: Jose Fonseca Thanks On 02/08/17 15:10, Eric Engestrom wrote: String handling has changed on python3. Before this patch: After: (No change on python2, it always looked ok) Cc: Jose Fonseca Fixes: b99dcbfeb344390fea99 "build: Convert git_sha1_gen script to Python."

Re: [Mesa-dev] [PATCH mesa] git_sha1_gen: fix output on python3

2017-08-02 Thread Jose Fonseca
Ah, yeah. We only expect an hash, so probably it's better to avoid UTF and presume output is ASCII: diff --git a/bin/git_sha1_gen.py b/bin/git_sha1_gen.py index 6d13db1e16..61e59e4131 100755 --- a/bin/git_sha1_gen.py +++ b/bin/git_sha1_gen.py @@ -17,4 +17,5 @@ except subprocess.CalledProcessErr

[Mesa-dev] [PATCH mesa] git_sha1_gen: fix output on python3

2017-08-02 Thread Eric Engestrom
String handling has changed on python3. Before this patch: After: (No change on python2, it always looked ok) Cc: Jose Fonseca Fixes: b99dcbfeb344390fea99 "build: Convert git_sha1_gen script to Python." Signed-off-by: Eric Engestrom --- bin/git_sha1_gen.py | 2 +- 1 file changed, 1 insertion(