Re: [Mesa-dev] [PATCH kmscube 2/3] add video cube

2017-03-27 Thread Rob Clark
On Mon, Mar 27, 2017 at 5:41 AM, Emil Velikov wrote: > >> + dec->egl->eglDestroyImageKHR(dec->egl->display, >> dec->last_frame); > > Unrelated: we must be using glGetString(GL_EXTENSIONS) and > eglQueryString(... EGL_EXTENSIONS) alongside eglGetProcAddress(). > It's not cool that km

Re: [Mesa-dev] [PATCH kmscube 2/3] add video cube

2017-03-27 Thread Emil Velikov
On 25 March 2017 at 20:11, Rob Clark wrote: > --- a/common.h > +++ b/common.h > > +#ifdef HAVE_CONFIG_H > +# include "config.h" > +#endif > + config.h is no more as of commit 24830fe38257c6b0df8fa86acfa8cdb08eb41dcf Drop the hunk. > #include > #include > #include > @@ -85,9 +89,25 @@ enu

[Mesa-dev] [PATCH kmscube 2/3] add video cube

2017-03-25 Thread Rob Clark
Uses gstreamer for a simple decoder. If decoder can give us dma-buf's directly, we'll directly use that as a texture (zero copy), otherwise memcpy into a buffer from gbm. This should work with both hw and sw decoders. Probably room for improvement. And the interface between gl and the decoder i