Re: [Mesa-dev] [PATCH kmscube] Search for a suitable config

2019-07-04 Thread Emil Velikov
On Wed, 3 Jul 2019 at 08:16, Drew DeVault wrote: > > Instead of assuming the first will be suitable. kmscube fails to start > for me without this change. Yes please. Picking the first one is rarely the correct thing to do. Especially when we have platform specific attributes which are exempt from

Re: [Mesa-dev] [PATCH kmscube] Search for a suitable config

2019-07-03 Thread Daniel Stone
Hi Drew, On Wed, 3 Jul 2019 at 08:16, Drew DeVault wrote: > Instead of assuming the first will be suitable. kmscube fails to start > for me without this change. There are a couple of unrelated changes combined in here, but I think the core one is good. eglChooseConfig has some really useful pro

[Mesa-dev] [PATCH kmscube] Search for a suitable config

2019-07-03 Thread Drew DeVault
Instead of assuming the first will be suitable. kmscube fails to start for me without this change. --- common.c | 52 +--- common.h | 1 + 2 files changed, 46 insertions(+), 7 deletions(-) diff --git a/common.c b/common.c index f9bd280..45c074d 100