Re: [Mesa-dev] [PATCH V3 7/8] glsl: remove remaining is_array variables

2014-01-22 Thread Timothy Arceri
> I'm guessing you missed this because you are building in release mode, so > asserts didn't get compiled.  If that's the > case, I'd like to encourage you > to do a debug build and double-check that piglit tests still pass.  You can > do that by > adding the "--enable-debug" option when you run

Re: [Mesa-dev] [PATCH V3 7/8] glsl: remove remaining is_array variables

2014-01-22 Thread Paul Berry
On 22 January 2014 03:33, Timothy Arceri wrote: > Previously the reason we needed is_array was because we used array_size == > NULL to > represent both non-arrays and unsized arrays. Now that we use a non-NULL > array_specifier to represent an unsized array, is_array is redundant. > > Signed-off

[Mesa-dev] [PATCH V3 7/8] glsl: remove remaining is_array variables

2014-01-22 Thread Timothy Arceri
Previously the reason we needed is_array was because we used array_size == NULL to represent both non-arrays and unsized arrays. Now that we use a non-NULL array_specifier to represent an unsized array, is_array is redundant. Signed-off-by: Timothy Arceri --- src/glsl/ast.h |