Re: [Mesa-dev] [PATCH V3 1/2] glsl: don't attempt to link empty program

2016-02-09 Thread Ian Romanick
On 01/25/2016 06:33 PM, Timothy Arceri wrote: > On Mon, 2016-01-25 at 16:58 -0800, Ian Romanick wrote: >> On 01/25/2016 04:46 PM, Timothy Arceri wrote: >>> Previously an empty program would go through the entire >>> link_shaders() function and we would have to be careful >>> not to cause a segfault

Re: [Mesa-dev] [PATCH V3 1/2] glsl: don't attempt to link empty program

2016-02-09 Thread Kenneth Graunke
On Tuesday, January 26, 2016 11:46:19 AM PST Timothy Arceri wrote: > Previously an empty program would go through the entire > link_shaders() function and we would have to be careful > not to cause a segfault. > > In core profile also now set link_status to false by > generating an error, it was p

Re: [Mesa-dev] [PATCH V3 1/2] glsl: don't attempt to link empty program

2016-01-26 Thread Timothy Arceri
On Tue, 2016-01-26 at 13:33 +1100, Timothy Arceri wrote: > On Mon, 2016-01-25 at 16:58 -0800, Ian Romanick wrote: > > On 01/25/2016 04:46 PM, Timothy Arceri wrote: > > > Previously an empty program would go through the entire > > > link_shaders() function and we would have to be careful > > > not t

Re: [Mesa-dev] [PATCH V3 1/2] glsl: don't attempt to link empty program

2016-01-25 Thread Timothy Arceri
On Mon, 2016-01-25 at 16:58 -0800, Ian Romanick wrote: > On 01/25/2016 04:46 PM, Timothy Arceri wrote: > > Previously an empty program would go through the entire > > link_shaders() function and we would have to be careful > > not to cause a segfault. > > > > In core profile also now set link_stat

Re: [Mesa-dev] [PATCH V3 1/2] glsl: don't attempt to link empty program

2016-01-25 Thread Ian Romanick
On 01/25/2016 04:46 PM, Timothy Arceri wrote: > Previously an empty program would go through the entire > link_shaders() function and we would have to be careful > not to cause a segfault. > > In core profile also now set link_status to false by > generating an error, it was previously set to true

[Mesa-dev] [PATCH V3 1/2] glsl: don't attempt to link empty program

2016-01-25 Thread Timothy Arceri
Previously an empty program would go through the entire link_shaders() function and we would have to be careful not to cause a segfault. In core profile also now set link_status to false by generating an error, it was previously set to true. From Section 7.3 (PROGRAM OBJECTS) of the OpenGL 4.5 sp