Re: [Mesa-dev] [PATCH V2] mesa: use build flag to ensure stack is realigned on x86

2014-12-08 Thread Matt Turner
On Mon, Dec 8, 2014 at 1:59 PM, Ian Romanick wrote: > On 12/08/2014 01:56 PM, Matt Turner wrote: >> On Mon, Dec 8, 2014 at 1:54 PM, Ian Romanick wrote: diff --git a/configure.ac b/configure.ac index b0df1bb..7dc435a 100644 --- a/configure.ac +++ b/configure.ac @@ -253,8 +

Re: [Mesa-dev] [PATCH V2] mesa: use build flag to ensure stack is realigned on x86

2014-12-08 Thread Matt Turner
On Sun, Dec 7, 2014 at 4:13 AM, Timothy Arceri wrote: > Nowadays GCC assumes stack pointer is 16-byte aligned even on 32-bits, but > that is an assumption OpenGL drivers (or any dynamic library for that matter) > can't afford to make as there are many closed- and open- source application > bina

Re: [Mesa-dev] [PATCH V2] mesa: use build flag to ensure stack is realigned on x86

2014-12-08 Thread Ian Romanick
On 12/08/2014 01:56 PM, Matt Turner wrote: > On Mon, Dec 8, 2014 at 1:54 PM, Ian Romanick wrote: >>> diff --git a/configure.ac b/configure.ac >>> index b0df1bb..7dc435a 100644 >>> --- a/configure.ac >>> +++ b/configure.ac >>> @@ -253,8 +253,9 @@ AC_SUBST([VISIBILITY_CXXFLAGS]) >>> dnl >>> dnl Op

Re: [Mesa-dev] [PATCH V2] mesa: use build flag to ensure stack is realigned on x86

2014-12-08 Thread Matt Turner
On Mon, Dec 8, 2014 at 1:54 PM, Ian Romanick wrote: >> diff --git a/configure.ac b/configure.ac >> index b0df1bb..7dc435a 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -253,8 +253,9 @@ AC_SUBST([VISIBILITY_CXXFLAGS]) >> dnl >> dnl Optional flags, check for compiler support >> dnl >>

Re: [Mesa-dev] [PATCH V2] mesa: use build flag to ensure stack is realigned on x86

2014-12-08 Thread Ian Romanick
On 12/07/2014 04:13 AM, Timothy Arceri wrote: > Nowadays GCC assumes stack pointer is 16-byte aligned even on 32-bits, but > that is an assumption OpenGL drivers (or any dynamic library for that matter) > can't afford to make as there are many closed- and open- source application > binaries out

Re: [Mesa-dev] [PATCH V2] mesa: use build flag to ensure stack is realigned on x86

2014-12-08 Thread Jose Fonseca
I'm not particularly knowledgeable about autoconf/make, but it looks correct AFAICT. Thanks for doing this. I think it would be useful to also add a comment somewhere on why -mstackrealign is necessary for 32-bits, for future reference. Reviewed-by: Jose Fonseca Jose On 07/12/14 12:13, Ti

[Mesa-dev] [PATCH V2] mesa: use build flag to ensure stack is realigned on x86

2014-12-07 Thread Timothy Arceri
Nowadays GCC assumes stack pointer is 16-byte aligned even on 32-bits, but that is an assumption OpenGL drivers (or any dynamic library for that matter) can't afford to make as there are many closed- and open- source application binaries out there that only assume 4-byte stack alignment. V2: us