Re: [Mesa-dev] [PATCH V2] intel/compiler: Make use of IS_INTEGER_DWORD macro

2017-05-26 Thread Kenneth Graunke
On Wednesday, May 24, 2017 10:06:01 AM PDT Matt Turner wrote: > On Wed, May 24, 2017 at 9:21 AM, Anuj Phogat wrote: > > This patch makes non-functional changes. > > > > V2: Rename IS_DWORD to IS_INTEGER_DWORD > > > To be honest, I don't like IS_DWORD/IS_INTEGER_DWORD -- for the same > reason Ale

Re: [Mesa-dev] [PATCH V2] intel/compiler: Make use of IS_INTEGER_DWORD macro

2017-05-24 Thread Anuj Phogat
On Wed, May 24, 2017 at 10:06 AM, Matt Turner wrote: > On Wed, May 24, 2017 at 9:21 AM, Anuj Phogat wrote: >> This patch makes non-functional changes. >> >> V2: Rename IS_DWORD to IS_INTEGER_DWORD > > > To be honest, I don't like IS_DWORD/IS_INTEGER_DWORD -- for the same > reason Alejandro noted.

Re: [Mesa-dev] [PATCH V2] intel/compiler: Make use of IS_INTEGER_DWORD macro

2017-05-24 Thread Matt Turner
On Wed, May 24, 2017 at 9:21 AM, Anuj Phogat wrote: > This patch makes non-functional changes. > > V2: Rename IS_DWORD to IS_INTEGER_DWORD To be honest, I don't like IS_DWORD/IS_INTEGER_DWORD -- for the same reason Alejandro noted. It's not clear what it means exactly, and in most cases it would

[Mesa-dev] [PATCH V2] intel/compiler: Make use of IS_INTEGER_DWORD macro

2017-05-24 Thread Anuj Phogat
This patch makes non-functional changes. V2: Rename IS_DWORD to IS_INTEGER_DWORD Signed-off-by: Anuj Phogat --- src/intel/compiler/brw_eu_defines.h | 3 +++ src/intel/compiler/brw_eu_emit.c | 24 +++- src/intel/compiler/brw_fs.cpp