Re: [Mesa-dev] [PATCH RFC] st/mesa: check st_context in st_renderbuffer_delete()

2018-09-05 Thread Olivier Fourdan
Hi Marek, On Thu, Aug 9, 2018 at 7:27 PM Marek Olšák wrote: > > This will leak the renderbuffer, but that's not the biggest problem. > > In your bug report, you said that the renderbuffer was created by > intel_new_renderbuffer, but this change is for st/mesa. Something is My comment in the bugz

Re: [Mesa-dev] [PATCH RFC] st/mesa: check st_context in st_renderbuffer_delete()

2018-09-04 Thread Olivier Fourdan
Hi Dave, On Thu, Aug 9, 2018 at 8:57 PM Dave Airlie wrote: > Sounds like a missing make current somewhere. Humm, the reproducer does a `glXMakeCurrent(dpy, 0, 0)` prior to destroying the context with `glXDestroyContext()`, removing that call to `glXMakeCurrent(dpy, 0, 0)` avoids the crash but it

Re: [Mesa-dev] [PATCH RFC] st/mesa: check st_context in st_renderbuffer_delete()

2018-08-09 Thread Dave Airlie
Sounds like a missing make current somewhere. Dave. On Fri., 10 Aug. 2018, 03:28 Marek Olšák, wrote: > This will leak the renderbuffer, but that's not the biggest problem. > > In your bug report, you said that the renderbuffer was created by > intel_new_renderbuffer, but this change is for st/m

Re: [Mesa-dev] [PATCH RFC] st/mesa: check st_context in st_renderbuffer_delete()

2018-08-09 Thread Marek Olšák
This will leak the renderbuffer, but that's not the biggest problem. In your bug report, you said that the renderbuffer was created by intel_new_renderbuffer, but this change is for st/mesa. Something is horribly wrong here. The intel driver should not ever end up in st/mesa, because st/mesa is a

Re: [Mesa-dev] [PATCH RFC] st/mesa: check st_context in st_renderbuffer_delete()

2018-08-07 Thread Olivier Fourdan
Hi, On Fri, Aug 3, 2018 at 7:03 PM Aaron Watry wrote: > > Tested-by: Aaron Watry > > Yay, I can finally use gnome/wayland with the Slack snap again without > insta-crashing my session. > > --Aaron > > On Thu, Aug 2, 2018 at 7:29 AM, Olivier Fourdan wrote: > > st_renderbuffer_delete() can segfau

Re: [Mesa-dev] [PATCH RFC] st/mesa: check st_context in st_renderbuffer_delete()

2018-08-03 Thread Aaron Watry
Tested-by: Aaron Watry Yay, I can finally use gnome/wayland with the Slack snap again without insta-crashing my session. --Aaron On Thu, Aug 2, 2018 at 7:29 AM, Olivier Fourdan wrote: > st_renderbuffer_delete() can segfault if we get a non-NULL context > pointer but if the st_context is NULL:

[Mesa-dev] [PATCH RFC] st/mesa: check st_context in st_renderbuffer_delete()

2018-08-02 Thread Olivier Fourdan
st_renderbuffer_delete() can segfault if we get a non-NULL context pointer but if the st_context is NULL: Thread 1 "Xwayland" received signal SIGSEGV, Segmentation fault. in st_renderbuffer_delete () at state_tracker/st_cb_fbo.c:241 241 pipe_surface_release(st->pipe, &strb->surface_srgb);