Re: [Mesa-dev] [PATCH RFC] intel/tools: new intel_sanitize_gpu tool

2018-02-07 Thread Scott D Phillips
"Rogovin, Kevin" writes: > HI Scott, > > I like the idea of making this a pre-loadable .so as it lets it get > reused for anything using the kernel interface using GEM's. However, > there are a few bits, that if addressed, would make this perfect IMO: > > 1. It needs a way of being able to l

Re: [Mesa-dev] [PATCH RFC] intel/tools: new intel_sanitize_gpu tool

2018-02-07 Thread Rogovin, Kevin
Hi, Two comments on the code you sent: 1. the map to find the size of a given GEM needs to be keyed by (fd, gem_handle) and not just the gem_handle; if an application (though very unlikely) has multiple fd's to the GPU (for example if an application made multiple connections to X, or if t

Re: [Mesa-dev] [PATCH RFC] intel/tools: new intel_sanitize_gpu tool

2018-02-07 Thread Rogovin, Kevin
HI Scott, I like the idea of making this a pre-loadable .so as it lets it get reused for anything using the kernel interface using GEM's. However, there are a few bits, that if addressed, would make this perfect IMO: 1. It needs a way of being able to label the GEMs (brw_bufmgr.c provides t

[Mesa-dev] [PATCH RFC] intel/tools: new intel_sanitize_gpu tool

2018-02-06 Thread Scott D Phillips
From: Kevin Rogovin Adds a new debug tool to pad each GEM BO allocated with (weak) pseudo-random noise values which are then checked after each batchbuffer dispatch to the kernel. This can be quite valuable to find diffucult to track down heisenberg style bugs. [scott.d.phill...@intel.com: split