Re: [Mesa-dev] [PATCH 8/9] nir: Add code to fixup bitfield_insert/extract.

2016-01-12 Thread Ian Romanick
On 01/11/2016 10:04 PM, Connor Abbott wrote: > On Tue, Jan 12, 2016 at 12:54 AM, Matt Turner wrote: >> On Mon, Jan 11, 2016 at 6:58 PM, Jason Ekstrand wrote: >>> >>> On Jan 11, 2016 2:47 PM, "Matt Turner" wrote: The OpenGL specifications for bitfieldInsert() and bitfieldExtract() says:

Re: [Mesa-dev] [PATCH 8/9] nir: Add code to fixup bitfield_insert/extract.

2016-01-11 Thread Jason Ekstrand
On Mon, Jan 11, 2016 at 10:04 PM, Connor Abbott wrote: > On Tue, Jan 12, 2016 at 12:54 AM, Matt Turner wrote: > > On Mon, Jan 11, 2016 at 6:58 PM, Jason Ekstrand > wrote: > >> > >> On Jan 11, 2016 2:47 PM, "Matt Turner" wrote: > >>> > >>> The OpenGL specifications for bitfieldInsert() and bitf

Re: [Mesa-dev] [PATCH 8/9] nir: Add code to fixup bitfield_insert/extract.

2016-01-11 Thread Connor Abbott
On Tue, Jan 12, 2016 at 12:54 AM, Matt Turner wrote: > On Mon, Jan 11, 2016 at 6:58 PM, Jason Ekstrand wrote: >> >> On Jan 11, 2016 2:47 PM, "Matt Turner" wrote: >>> >>> The OpenGL specifications for bitfieldInsert() and bitfieldExtract() says: >>> >>>The result will be undefined if or is

Re: [Mesa-dev] [PATCH 8/9] nir: Add code to fixup bitfield_insert/extract.

2016-01-11 Thread Matt Turner
On Mon, Jan 11, 2016 at 6:58 PM, Jason Ekstrand wrote: > > On Jan 11, 2016 2:47 PM, "Matt Turner" wrote: >> >> The OpenGL specifications for bitfieldInsert() and bitfieldExtract() says: >> >>The result will be undefined if or is negative, or if >>the sum of and is greater than the num

Re: [Mesa-dev] [PATCH 8/9] nir: Add code to fixup bitfield_insert/extract.

2016-01-11 Thread Jason Ekstrand
On Jan 11, 2016 2:47 PM, "Matt Turner" wrote: > > The OpenGL specifications for bitfieldInsert() and bitfieldExtract() says: > >The result will be undefined if or is negative, or if >the sum of and is greater than the number of bits >used to store the operand. > > Therefore passing

[Mesa-dev] [PATCH 8/9] nir: Add code to fixup bitfield_insert/extract.

2016-01-11 Thread Matt Turner
The OpenGL specifications for bitfieldInsert() and bitfieldExtract() says: The result will be undefined if or is negative, or if the sum of and is greater than the number of bits used to store the operand. Therefore passing bits=32, offset=0 is legal and defined in GLSL. But the ear