Re: [Mesa-dev] [PATCH 7/9] spirv: Add vtn_fail and vtn_assert helpers

2017-09-05 Thread Jason Ekstrand
On Tue, Sep 5, 2017 at 5:32 PM, Ian Romanick wrote: > On 08/17/2017 10:22 AM, Jason Ekstrand wrote: > > These helpers are much nicer than just using assert because they don't > > kill your process. Instead, it longjmps back to spirv_to_nir(), cleans > > up all the temporary memory, and nicely re

Re: [Mesa-dev] [PATCH 7/9] spirv: Add vtn_fail and vtn_assert helpers

2017-09-05 Thread Ian Romanick
On 08/17/2017 10:22 AM, Jason Ekstrand wrote: > These helpers are much nicer than just using assert because they don't > kill your process. Instead, it longjmps back to spirv_to_nir(), cleans > up all the temporary memory, and nicely returns NULL. While crashing is > completely OK in the Vulkan w

Re: [Mesa-dev] [PATCH 7/9] spirv: Add vtn_fail and vtn_assert helpers

2017-08-17 Thread Jason Ekstrand
On Thu, Aug 17, 2017 at 10:29 AM, Erik Faye-Lund wrote: > On Thu, Aug 17, 2017 at 7:22 PM, Jason Ekstrand > wrote: > > These helpers are much nicer than just using assert because they don't > > kill your process. Instead, it longjmps back to spirv_to_nir(), cleans > > up all the temporary memor

Re: [Mesa-dev] [PATCH 7/9] spirv: Add vtn_fail and vtn_assert helpers

2017-08-17 Thread Erik Faye-Lund
On Thu, Aug 17, 2017 at 7:22 PM, Jason Ekstrand wrote: > These helpers are much nicer than just using assert because they don't > kill your process. Instead, it longjmps back to spirv_to_nir(), cleans > up all the temporary memory, and nicely returns NULL. While crashing is > completely OK in th

[Mesa-dev] [PATCH 7/9] spirv: Add vtn_fail and vtn_assert helpers

2017-08-17 Thread Jason Ekstrand
These helpers are much nicer than just using assert because they don't kill your process. Instead, it longjmps back to spirv_to_nir(), cleans up all the temporary memory, and nicely returns NULL. While crashing is completely OK in the Vulkan world, it's not considered to be quite so nice in GL.