Re: [Mesa-dev] [PATCH 7/7] softpipe: Constify variables

2015-09-11 Thread Roland Scheidegger
Honestly, I don't see much point of constifying simple one-time-assigned local variables (won't make a difference to the compiler anyway, and even for reading imho doesn't add much). I don't object changing it though, and the rest of the series definitely looks good to me, I'm glad you got rid of t

[Mesa-dev] [PATCH 7/7] softpipe: Constify variables

2015-09-11 Thread Krzesimir Nowak
This commit makes a lot of variables constant - this is basically done by moving the computation to variable definition. Some of them are moved into lower scopes (like in img_filter_2d_ewa). --- src/gallium/drivers/softpipe/sp_tex_sample.c | 441 --- 1 file changed, 199 ins