Re: [Mesa-dev] [PATCH 6/9] intel/fs: Use the new nir_src_is_const and friends

2018-11-07 Thread Jason Ekstrand
On Wed, Nov 7, 2018 at 4:06 PM Kenneth Graunke wrote: > On Wednesday, November 7, 2018 1:45:59 PM PST Jason Ekstrand wrote: > > On Wed, Nov 7, 2018 at 12:20 PM Kenneth Graunke > > wrote: > > > > > On Saturday, October 20, 2018 10:55:44 AM PST Jason Ekstrand wrote: > > > > @@ -553,14 +552,18 @@ >

Re: [Mesa-dev] [PATCH 6/9] intel/fs: Use the new nir_src_is_const and friends

2018-11-07 Thread Kenneth Graunke
On Wednesday, November 7, 2018 1:45:59 PM PST Jason Ekstrand wrote: > On Wed, Nov 7, 2018 at 12:20 PM Kenneth Graunke > wrote: > > > On Saturday, October 20, 2018 10:55:44 AM PST Jason Ekstrand wrote: > > > @@ -553,14 +552,18 @@ > > fs_visitor::optimize_frontfacing_ternary(nir_alu_instr *instr, >

Re: [Mesa-dev] [PATCH 6/9] intel/fs: Use the new nir_src_is_const and friends

2018-11-07 Thread Jason Ekstrand
On Wed, Nov 7, 2018 at 12:20 PM Kenneth Graunke wrote: > On Saturday, October 20, 2018 10:55:44 AM PST Jason Ekstrand wrote: > > @@ -553,14 +552,18 @@ > fs_visitor::optimize_frontfacing_ternary(nir_alu_instr *instr, > > if (src0->intrinsic != nir_intrinsic_load_front_face) > >return f

Re: [Mesa-dev] [PATCH 6/9] intel/fs: Use the new nir_src_is_const and friends

2018-11-07 Thread Kenneth Graunke
On Saturday, October 20, 2018 10:55:44 AM PST Jason Ekstrand wrote: > @@ -553,14 +552,18 @@ fs_visitor::optimize_frontfacing_ternary(nir_alu_instr > *instr, > if (src0->intrinsic != nir_intrinsic_load_front_face) >return false; > > - nir_const_value *value1 = nir_src_as_const_value

[Mesa-dev] [PATCH 6/9] intel/fs: Use the new nir_src_is_const and friends

2018-10-20 Thread Jason Ekstrand
As of this commit, all uses of const sources either go through a nir_src_as_ helper which handles bit sizes correctly or else are accompanied by a nir_src_bit_size() == 32 assertion to assert that we have the size we think we have. --- src/intel/compiler/brw_fs_nir.cpp | 200 ++