Re: [Mesa-dev] [PATCH 6/9] glcpp: Skip unnecessary line continuations removal

2017-05-21 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 22/05/17 06:49, Thomas Helland wrote: From: Vladislav Egorov Overwhelming majority of shaders don't use line continuations. In my shader-db only shaders from the Talos Principle and Serious Sam used them, less than 1% out of all shaders. Optimize for this case,

[Mesa-dev] [PATCH 6/9] glcpp: Skip unnecessary line continuations removal

2017-05-21 Thread Thomas Helland
From: Vladislav Egorov Overwhelming majority of shaders don't use line continuations. In my shader-db only shaders from the Talos Principle and Serious Sam used them, less than 1% out of all shaders. Optimize for this case, don't do any copying if no line continuation was found. --- src/compiler