Re: [Mesa-dev] [PATCH 6/7] i965: Don't use PREAD for glGetBufferSubData().

2017-07-07 Thread Chris Wilson
Quoting Kenneth Graunke (2017-07-07 06:19:07) > On Thursday, July 6, 2017 4:21:28 AM PDT Chris Wilson wrote: > > Quoting Kenneth Graunke (2017-07-05 21:56:53) > > > diff --git a/src/mesa/drivers/dri/i965/intel_buffer_objects.c > > > b/src/mesa/drivers/dri/i965/intel_buffer_objects.c > > > index a9

Re: [Mesa-dev] [PATCH 6/7] i965: Don't use PREAD for glGetBufferSubData().

2017-07-06 Thread Kenneth Graunke
On Thursday, July 6, 2017 4:21:28 AM PDT Chris Wilson wrote: > Quoting Kenneth Graunke (2017-07-05 21:56:53) > > diff --git a/src/mesa/drivers/dri/i965/intel_buffer_objects.c > > b/src/mesa/drivers/dri/i965/intel_buffer_objects.c > > index a9ac29a6a81..2b0f7b9a698 100644 > > --- a/src/mesa/drivers

Re: [Mesa-dev] [PATCH 6/7] i965: Don't use PREAD for glGetBufferSubData().

2017-07-06 Thread Chris Wilson
Quoting Kenneth Graunke (2017-07-05 21:56:53) > diff --git a/src/mesa/drivers/dri/i965/intel_buffer_objects.c > b/src/mesa/drivers/dri/i965/intel_buffer_objects.c > index a9ac29a6a81..2b0f7b9a698 100644 > --- a/src/mesa/drivers/dri/i965/intel_buffer_objects.c > +++ b/src/mesa/drivers/dri/i965/inte

[Mesa-dev] [PATCH 6/7] i965: Don't use PREAD for glGetBufferSubData().

2017-07-05 Thread Kenneth Graunke
Just map the buffer and memcpy. This will do a CPU mmap, which should be reasonably efficient, and doing this gives us full control over the domains and caching instead of leaving it to the kernel. This prevents regressions on Braswell in the next commit. Specifically GL45-CTS.shader_atomic_coun