Re: [Mesa-dev] [PATCH 6/6] panfrost: Add support for TXS instructions

2019-06-17 Thread Boris Brezillon
On Mon, 17 Jun 2019 07:05:24 -0700 Alyssa Rosenzweig wrote: > > +/* > > + * Note: the first call is here to lower RECT and TXP, the second > > one > > + * to lower the TXS(lod) instructions generated by the RECT > > lowering > > + * done in the first pass. > > +

Re: [Mesa-dev] [PATCH 6/6] panfrost: Add support for TXS instructions

2019-06-17 Thread Alyssa Rosenzweig
> +/* > + * Note: the first call is here to lower RECT and TXP, the second one > + * to lower the TXS(lod) instructions generated by the RECT lowering > + * done in the first pass. > + * > + * FIXME: we should probably have a > + * > +

[Mesa-dev] [PATCH 6/6] panfrost: Add support for TXS instructions

2019-06-17 Thread Boris Brezillon
This patch adds support for nir_texop_txs instructions which are needed to support the OpenGL textureSize() function. This is also needed to support RECT texture sampling which is currently lowered to 2D sampling + a TXS() instruction by the nir_lower_tex() helper. Signed-off-by: Boris Brezillon