Re: [Mesa-dev] [PATCH 6/6] mesa/st: add ARB_uniform_buffer_object support

2012-12-16 Thread Marek Olšák
ctx->Const.UniformBufferOffsetAlignment should be set to PIPE_CAP_CONSTANT_BUFFER_OFFSET_ALIGNMENT. I added the cap exactly for that purpose. The default value for UniformBufferOffsetAlignment is 1, but R600 requires the alignment to be 256 bytes. The other 3 UBO limits in Const could also be set

Re: [Mesa-dev] [PATCH 6/6] mesa/st: add ARB_uniform_buffer_object support

2012-12-06 Thread Brian Paul
On 12/05/2012 11:24 PM, Dave Airlie wrote: From: Dave Airlie this adds UBO support to the state tracker, it works with softpipe as-is. It uses UARL + CONST[x][ADDR[0].x] type constructs. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_atom.c | 2 + src/mesa/state_track

Re: [Mesa-dev] [PATCH 6/6] mesa/st: add ARB_uniform_buffer_object support

2012-12-06 Thread Jose Fonseca
Series looks good AFAICT. Jose - Original Message - > From: Dave Airlie > > this adds UBO support to the state tracker, it works with softpipe > as-is. > > It uses UARL + CONST[x][ADDR[0].x] type constructs. > > Signed-off-by: Dave Airlie > --- > src/mesa/state_tracker/st_atom.c

[Mesa-dev] [PATCH 6/6] mesa/st: add ARB_uniform_buffer_object support

2012-12-06 Thread Dave Airlie
From: Dave Airlie this adds UBO support to the state tracker, it works with softpipe as-is. It uses UARL + CONST[x][ADDR[0].x] type constructs. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_atom.c | 2 + src/mesa/state_tracker/st_atom.h | 2 + src/mesa/sta