Re: [Mesa-dev] [PATCH 6/6] mesa/main: fix incorrect detph-error

2018-11-26 Thread Erik Faye-Lund
On Mon, 2018-11-26 at 13:16 +0100, Juan A. Suarez Romero wrote: > On Mon, 2018-11-26 at 13:13 +0100, Erik Faye-Lund wrote: > > On Mon, 2018-11-26 at 13:06 +0100, Juan A. Suarez Romero wrote: > > > On Thu, 2018-11-22 at 17:48 +0100, Erik Faye-Lund wrote: > > > > If glGetTexImage or glGetnTexImage is

Re: [Mesa-dev] [PATCH 6/6] mesa/main: fix incorrect detph-error

2018-11-26 Thread Juan A. Suarez Romero
On Mon, 2018-11-26 at 13:13 +0100, Erik Faye-Lund wrote: > On Mon, 2018-11-26 at 13:06 +0100, Juan A. Suarez Romero wrote: > > On Thu, 2018-11-22 at 17:48 +0100, Erik Faye-Lund wrote: > > > If glGetTexImage or glGetnTexImage is called with a level that > > > doesn't > > > exist, we get an error mes

Re: [Mesa-dev] [PATCH 6/6] mesa/main: fix incorrect detph-error

2018-11-26 Thread Erik Faye-Lund
On Mon, 2018-11-26 at 13:06 +0100, Juan A. Suarez Romero wrote: > On Thu, 2018-11-22 at 17:48 +0100, Erik Faye-Lund wrote: > > If glGetTexImage or glGetnTexImage is called with a level that > > doesn't > > exist, we get an error message on this form: > > > > Mesa: User error: GL_INVALID_VALUE in g

Re: [Mesa-dev] [PATCH 6/6] mesa/main: fix incorrect detph-error

2018-11-26 Thread Juan A. Suarez Romero
On Thu, 2018-11-22 at 17:48 +0100, Erik Faye-Lund wrote: > If glGetTexImage or glGetnTexImage is called with a level that doesn't > exist, we get an error message on this form: > > Mesa: User error: GL_INVALID_VALUE in glGetTexImage(depth = 0) > > This is clearly nonsensical, because these APIs d

Re: [Mesa-dev] [PATCH 6/6] mesa/main: fix incorrect detph-error

2018-11-23 Thread Juan A. Suarez Romero
On Thu, 2018-11-22 at 17:48 +0100, Erik Faye-Lund wrote: Typo in the subject (s/detph/depth) > If glGetTexImage or glGetnTexImage is called with a level that doesn't > exist, we get an error message on this form: > > Mesa: User error: GL_INVALID_VALUE in glGetTexImage(depth = 0) > > This is cle

[Mesa-dev] [PATCH 6/6] mesa/main: fix incorrect detph-error

2018-11-22 Thread Erik Faye-Lund
If glGetTexImage or glGetnTexImage is called with a level that doesn't exist, we get an error message on this form: Mesa: User error: GL_INVALID_VALUE in glGetTexImage(depth = 0) This is clearly nonsensical, because these APIs don't even have a depth-parameter. The reason is that get_texture_imag