Re: [Mesa-dev] [PATCH 5/8] i965/upload: Actually comment the upload code.

2014-03-13 Thread Kenneth Graunke
On 03/13/2014 09:05 AM, Ian Romanick wrote: > On 03/13/2014 01:57 AM, Kenneth Graunke wrote: >> diff --git a/src/mesa/drivers/dri/i965/intel_upload.c >> b/src/mesa/drivers/dri/i965/intel_upload.c >> index ec3109b..c767b7d 100644 >> --- a/src/mesa/drivers/dri/i965/intel_upload.c >> +++ b/src/mesa/d

Re: [Mesa-dev] [PATCH 5/8] i965/upload: Actually comment the upload code.

2014-03-13 Thread Ian Romanick
On 03/13/2014 01:57 AM, Kenneth Graunke wrote: > diff --git a/src/mesa/drivers/dri/i965/intel_upload.c > b/src/mesa/drivers/dri/i965/intel_upload.c > index ec3109b..c767b7d 100644 > --- a/src/mesa/drivers/dri/i965/intel_upload.c > +++ b/src/mesa/drivers/dri/i965/intel_upload.c > @@ -25,7 +25,16 @@

[Mesa-dev] [PATCH 5/8] i965/upload: Actually comment the upload code.

2014-03-13 Thread Kenneth Graunke
This code literally had zero comments, which made it impenetrable for basically everybody except the authors. We still ought to comment the refcounting strategy. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.h | 24 +++ src/mesa/drivers/dri/i965/intel_upload.c |