Re: [Mesa-dev] [PATCH 5/6] mesa: replace _ASMAPI with __cdecl

2015-03-11 Thread Jose Fonseca
On 11/03/15 16:52, Brian Paul wrote: On 03/11/2015 08:21 AM, Jose Fonseca wrote: On 11/03/15 14:07, Brian Paul wrote: On 03/11/2015 01:29 AM, Jose Fonseca wrote: I don't know the story about this _ASMAPI macro, but __cdecl is also the default calling convention for WIN32: https://msdn.micr

Re: [Mesa-dev] [PATCH 5/6] mesa: replace _ASMAPI with __cdecl

2015-03-11 Thread Brian Paul
On 03/11/2015 08:21 AM, Jose Fonseca wrote: On 11/03/15 14:07, Brian Paul wrote: On 03/11/2015 01:29 AM, Jose Fonseca wrote: I don't know the story about this _ASMAPI macro, but __cdecl is also the default calling convention for WIN32: https://msdn.microsoft.com/en-us/library/zkwh89ks.aspx

Re: [Mesa-dev] [PATCH 5/6] mesa: replace _ASMAPI with __cdecl

2015-03-11 Thread Jose Fonseca
On 11/03/15 14:07, Brian Paul wrote: On 03/11/2015 01:29 AM, Jose Fonseca wrote: I don't know the story about this _ASMAPI macro, but __cdecl is also the default calling convention for WIN32: https://msdn.microsoft.com/en-us/library/zkwh89ks.aspx Yeah, I had read that too actually but I fi

Re: [Mesa-dev] [PATCH 5/6] mesa: replace _ASMAPI with __cdecl

2015-03-11 Thread Brian Paul
On 03/11/2015 01:29 AM, Jose Fonseca wrote: I don't know the story about this _ASMAPI macro, but __cdecl is also the default calling convention for WIN32: https://msdn.microsoft.com/en-us/library/zkwh89ks.aspx Yeah, I had read that too actually but I figured it was safer to keep things as-

Re: [Mesa-dev] [PATCH 5/6] mesa: replace _ASMAPI with __cdecl

2015-03-11 Thread Jose Fonseca
I don't know the story about this _ASMAPI macro, but __cdecl is also the default calling convention for WIN32: https://msdn.microsoft.com/en-us/library/zkwh89ks.aspx so it's redundant to add it. (The other common calling convention -- __stdcall/APIENTRY/etc -- is the one that must always be

Re: [Mesa-dev] [PATCH 5/6] mesa: replace _ASMAPI with __cdecl

2015-03-10 Thread Matt Turner
On Tue, Mar 10, 2015 at 6:44 PM, Brian Paul wrote: > __cdecl is the MSVC directive use to indicate caller stack cleanup. > We typically annotate code-generated functions with __cdecl so we can > use the same code on all platforms. > > A new #define like CDECL would be nicer, but CDECL is already d

[Mesa-dev] [PATCH 5/6] mesa: replace _ASMAPI with __cdecl

2015-03-10 Thread Brian Paul
__cdecl is the MSVC directive use to indicate caller stack cleanup. We typically annotate code-generated functions with __cdecl so we can use the same code on all platforms. A new #define like CDECL would be nicer, but CDECL is already defined in minwindef.h on Windows. --- src/mesa/main/compiler