On 05/31/2017 02:04 AM, Samuel Pitoiset wrote:
>
>
> On 05/31/2017 02:46 AM, Ian Romanick wrote:
>> On 05/25/2017 11:07 AM, Samuel Pitoiset wrote:
>>> Memory/format layout qualifiers shouldn't be lost when arrays
>>> of images are splitted by this pass.
>>>
>>> Signed-off-by: Samuel Pitoiset
>>>
On 05/31/2017 11:34 AM, Timothy Arceri wrote:
On 31/05/17 19:04, Samuel Pitoiset wrote:
On 05/31/2017 02:46 AM, Ian Romanick wrote:
On 05/25/2017 11:07 AM, Samuel Pitoiset wrote:
Memory/format layout qualifiers shouldn't be lost when arrays
of images are splitted by this pass.
Signed-of
On 31/05/17 19:04, Samuel Pitoiset wrote:
On 05/31/2017 02:46 AM, Ian Romanick wrote:
On 05/25/2017 11:07 AM, Samuel Pitoiset wrote:
Memory/format layout qualifiers shouldn't be lost when arrays
of images are splitted by this pass.
Signed-off-by: Samuel Pitoiset
---
src/compiler/glsl/op
On 05/31/2017 02:46 AM, Ian Romanick wrote:
On 05/25/2017 11:07 AM, Samuel Pitoiset wrote:
Memory/format layout qualifiers shouldn't be lost when arrays
of images are splitted by this pass.
Signed-off-by: Samuel Pitoiset
---
src/compiler/glsl/opt_array_splitting.cpp | 17 +++--
On 05/25/2017 11:07 AM, Samuel Pitoiset wrote:
> Memory/format layout qualifiers shouldn't be lost when arrays
> of images are splitted by this pass.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/compiler/glsl/opt_array_splitting.cpp | 17 +++--
> 1 file changed, 15 insertions(+), 2
Again I'd rather contains_image() -> without_array()->is_image()
The array we a splitting could contain a struct, nested struct etc.
There is no need to recurse the structs/interface and attempt to copy
the empty memory qualifiers.
With that change:
Reviewed-by: Timothy Arceri
On 26/05/17
Memory/format layout qualifiers shouldn't be lost when arrays
of images are splitted by this pass.
Signed-off-by: Samuel Pitoiset
---
src/compiler/glsl/opt_array_splitting.cpp | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/src/compiler/glsl/opt_array_split
