Re: [Mesa-dev] [PATCH 5/5] nir: Add nir_lower_alu_scalar.

2015-01-22 Thread Eric Anholt
Jason Ekstrand writes: > Overall this looks correct. I've got a few nits below and I'd like to take > a look at it with fresh eyes before giving an R-B as it's complicated > especially with all of the stuff to handle non-ssa. Not sure if it's > really worth doing non-ssa now that I see how much

Re: [Mesa-dev] [PATCH 5/5] nir: Add nir_lower_alu_scalar.

2015-01-21 Thread Jason Ekstrand
Overall this looks correct. I've got a few nits below and I'd like to take a look at it with fresh eyes before giving an R-B as it's complicated especially with all of the stuff to handle non-ssa. Not sure if it's really worth doing non-ssa now that I see how much more complicated it makes things

[Mesa-dev] [PATCH 5/5] nir: Add nir_lower_alu_scalar.

2015-01-21 Thread Eric Anholt
This is the equivalent of brw_fs_channel_expressions.cpp, which I wanted for vc4. --- This series, plus a commit to make i965 use it instead of channel_expressions, is on the nir-scalarize branch of my mesa tree. With the whole series, there are 6 regressions, 3 of which are due to lower-vec-to-m