Re: [Mesa-dev] [PATCH 5/5] nir/cse: use the instr_hash helper

2015-08-18 Thread Jason Ekstrand
On Fri, May 22, 2015 at 11:24 AM, Connor Abbott wrote: > This replaces an O(n^2) algorithm with an O(n) one, while allowing us to > import most of the infrastructure required for GVN. The idea is to walk > the dominance tree depth-first, similar when converting to SSA, and > remove the instruction

Re: [Mesa-dev] [PATCH 5/5] nir/cse: use the instr_hash helper

2015-08-18 Thread Jason Ekstrand
I really like this. It's nice, straight-forward, and to-the-point. Once the other issues have been cleared up, Reviewed-by: Jason Ekstrand On Fri, May 22, 2015 at 11:24 AM, Connor Abbott wrote: > This replaces an O(n^2) algorithm with an O(n) one, while allowing us to > import most of the infr

[Mesa-dev] [PATCH 5/5] nir/cse: use the instr_hash helper

2015-05-22 Thread Connor Abbott
This replaces an O(n^2) algorithm with an O(n) one, while allowing us to import most of the infrastructure required for GVN. The idea is to walk the dominance tree depth-first, similar when converting to SSA, and remove the instructions from the set when we're done visiting the sub-tree of the domi