Re: [Mesa-dev] [PATCH 5/5] llvmpipe: disable simple_shader optimization

2013-05-22 Thread Jose Fonseca
Roland, Series looks good AFAICT. Thanks for nailing this nasty and long standing issues. - Original Message - > On Tue, May 21, 2013 at 6:12 PM, wrote: > > From: Roland Scheidegger > > > > This optimization disabled mask checks if the shader is simple enough. > > While this should wo

Re: [Mesa-dev] [PATCH 5/5] llvmpipe: disable simple_shader optimization

2013-05-21 Thread Alex Deucher
On Tue, May 21, 2013 at 6:12 PM, wrote: > From: Roland Scheidegger > > This optimization disabled mask checks if the shader is simple enough. > While this should work correctly, the problem is that it can hide real issues > because shaders in practice are usually complex enough (8 instructions o

[Mesa-dev] [PATCH 5/5] llvmpipe: disable simple_shader optimization

2013-05-21 Thread sroland
From: Roland Scheidegger This optimization disabled mask checks if the shader is simple enough. While this should work correctly, the problem is that it can hide real issues because shaders in practice are usually complex enough (8 instructions or 1 texture is already enough) so this doesn't get