Re: [Mesa-dev] [PATCH 5/5] i965: Optimize batchbuffer macros.

2015-07-13 Thread Matt Turner
On Sat, Jul 11, 2015 at 11:02 AM, Chris Wilson wrote: > On Fri, Jul 10, 2015 at 11:44:59AM -0700, Matt Turner wrote: >> Previously OUT_BATCH was just a macro around an inline function which >> does >> >>brw->batch.map[brw->batch.used++] = dword; >> >> When making consecutive calls to intel_bat

Re: [Mesa-dev] [PATCH 5/5] i965: Optimize batchbuffer macros.

2015-07-11 Thread Chris Wilson
On Fri, Jul 10, 2015 at 11:44:59AM -0700, Matt Turner wrote: > Previously OUT_BATCH was just a macro around an inline function which > does > >brw->batch.map[brw->batch.used++] = dword; > > When making consecutive calls to intel_batchbuffer_emit_dword() the > compiler isn't able to recognize

[Mesa-dev] [PATCH 5/5] i965: Optimize batchbuffer macros.

2015-07-10 Thread Matt Turner
Previously OUT_BATCH was just a macro around an inline function which does brw->batch.map[brw->batch.used++] = dword; When making consecutive calls to intel_batchbuffer_emit_dword() the compiler isn't able to recognize that we're writing consecutive memory locations or that it doesn't need to