Re: [Mesa-dev] [PATCH 5/5] glsl: Add frexp signatures and implementation.

2013-09-11 Thread Matt Turner
On Wed, Sep 11, 2013 at 10:03 AM, Paul Berry wrote: > On 9 September 2013 15:14, Matt Turner wrote: >> >> I initially implemented frexp() as an IR opcode with a lowering pass, >> but since it returns a value and has an out-parameter, it would break >> assumptions our optimization passes make abou

Re: [Mesa-dev] [PATCH 5/5] glsl: Add frexp signatures and implementation.

2013-09-11 Thread Paul Berry
On 9 September 2013 15:14, Matt Turner wrote: > I initially implemented frexp() as an IR opcode with a lowering pass, > but since it returns a value and has an out-parameter, it would break > assumptions our optimization passes make about ir_expressions being pure > (i.e., having no side effects)

[Mesa-dev] [PATCH 5/5] glsl: Add frexp signatures and implementation.

2013-09-09 Thread Matt Turner
I initially implemented frexp() as an IR opcode with a lowering pass, but since it returns a value and has an out-parameter, it would break assumptions our optimization passes make about ir_expressions being pure (i.e., having no side effects). For example, if opt_tree_grafting encounters this cod