Re: [Mesa-dev] [PATCH 5/5] gallium/targets: Move api init into st code

2015-05-15 Thread Emil Velikov
On 14/05/15 22:39, Alexander von Gluck IV wrote: > We also reduce the amount of need-to-know information about st_api > to require one less extern "C" in st_manager.h > --- > .../targets/haiku-softpipe/GalliumContext.cpp | 23 +++ > .../targets/haiku-softpipe/GalliumContext.

Re: [Mesa-dev] [PATCH 5/5] gallium/targets: Move api init into st code

2015-05-15 Thread Alexander von Gluck IV
can-do. I actually think I spotted one more extern "C" reduction I can do. Thanks! -- Alex On , Brian Paul wrote: Let's play it safe. Update your patch series and re-post it to the list for a final review, please. -Brian On 05/14/2015 06:01 PM, Alexander von Gluck IV wrote: Good evenin

Re: [Mesa-dev] [PATCH 5/5] gallium/targets: Move api init into st code

2015-05-15 Thread Brian Paul
Let's play it safe. Update your patch series and re-post it to the list for a final review, please. -Brian On 05/14/2015 06:01 PM, Alexander von Gluck IV wrote: Good evening Brian, Thanks, these were fixed. I just realized that I can drop os_thread.h from our C++ code as we no longer depen

Re: [Mesa-dev] [PATCH 5/5] gallium/targets: Move api init into st code

2015-05-14 Thread Alexander von Gluck IV
Good evening Brian, Thanks, these were fixed. I just realized that I can drop os_thread.h from our C++ code as we no longer depend on it and not do the extern "C" there. (tested working) You ok with this changeset with the change above? (I'd hate to commit it, then undo it) Thanks! -- Ale

Re: [Mesa-dev] [PATCH 5/5] gallium/targets: Move api init into st code

2015-05-14 Thread Brian Paul
In the past, you used the prefix "target/haiku-softpipe:" on changes to this code. I'd suggest using that again here. With these changes, Reviewed-by: Brian Paul On 05/14/2015 04:39 PM, Alexander von Gluck IV wrote: We also reduce the amount of need-to-know information about st_api to requir

[Mesa-dev] [PATCH 5/5] gallium/targets: Move api init into st code

2015-05-14 Thread Alexander von Gluck IV
We also reduce the amount of need-to-know information about st_api to require one less extern "C" in st_manager.h --- .../targets/haiku-softpipe/GalliumContext.cpp | 23 +++ .../targets/haiku-softpipe/GalliumContext.h|5 +--- 2 files changed, 10 insertions(+), 18