Re: [Mesa-dev] [PATCH 44/53] st/nine: Implement ps3 advanced input definition feature

2015-01-10 Thread Axel Davy
On 08/01/2015 05:01, Ilia Mirkin wrote : On Wed, Jan 7, 2015 at 11:36 AM, Axel Davy wrote: ps3 allows definitions of the inputs like: DCL_TEXCOORD0 v0.xy; Could this be .xw? I assume not... but if it can, that's not handled in this change. I think this patch should be improved, and since we

Re: [Mesa-dev] [PATCH 44/53] st/nine: Implement ps3 advanced input definition feature

2015-01-07 Thread Ilia Mirkin
On Wed, Jan 7, 2015 at 11:36 AM, Axel Davy wrote: > ps3 allows definitions of the inputs like: > DCL_TEXCOORD0 v0.xy; Could this be .xw? I assume not... but if it can, that's not handled in this change. > DCL_NORMAL2 v0.z; > DCL_NORMAL3 v0.w; > > Nine wouldn't have handled this situation properl

[Mesa-dev] [PATCH 44/53] st/nine: Implement ps3 advanced input definition feature

2015-01-07 Thread Axel Davy
ps3 allows definitions of the inputs like: DCL_TEXCOORD0 v0.xy; DCL_NORMAL2 v0.z; DCL_NORMAL3 v0.w; Nine wouldn't have handled this situation properly. Apparently very few applications use this feature. Still remain an issue with this new implementation: It is allowed to do indirect addressing o