Re: [Mesa-dev] [PATCH 4/9] glcpp: Avoid unnecessary strcmp()

2017-05-22 Thread Erik Faye-Lund
On Sun, May 21, 2017 at 10:49 PM, Thomas Helland wrote: > From: Vladislav Egorov > > strcmp() is slow. Initiate comparison with "__LINE__" or "__FILE__" > only if the identifier starts with '_', which is rare. > > Reviewed-by: Ian Romanick > --- > src/compiler/glsl/glcpp/glcpp-parse.y | 14

Re: [Mesa-dev] [PATCH 4/9] glcpp: Avoid unnecessary strcmp()

2017-05-21 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 22/05/17 06:49, Thomas Helland wrote: From: Vladislav Egorov strcmp() is slow. Initiate comparison with "__LINE__" or "__FILE__" only if the identifier starts with '_', which is rare. Reviewed-by: Ian Romanick --- src/compiler/glsl/glcpp/glcpp-parse.y | 14 +

[Mesa-dev] [PATCH 4/9] glcpp: Avoid unnecessary strcmp()

2017-05-21 Thread Thomas Helland
From: Vladislav Egorov strcmp() is slow. Initiate comparison with "__LINE__" or "__FILE__" only if the identifier starts with '_', which is rare. Reviewed-by: Ian Romanick --- src/compiler/glsl/glcpp/glcpp-parse.y | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git