Re: [Mesa-dev] [PATCH 4/8] i965/fs: Fix nir_op_fsign of absolute value.

2017-01-26 Thread Ian Romanick
On 01/25/2017 01:42 PM, Francisco Jerez wrote: > Ian Romanick writes: > >> On 01/24/2017 03:26 PM, Francisco Jerez wrote: >>> This does point at the front-end emitting silly code that could have >>> been optimized out, but the current fsign implementation would emit >>> bogus IR if abs was set fo

Re: [Mesa-dev] [PATCH 4/8] i965/fs: Fix nir_op_fsign of absolute value.

2017-01-25 Thread Francisco Jerez
Ian Romanick writes: > On 01/24/2017 03:26 PM, Francisco Jerez wrote: >> This does point at the front-end emitting silly code that could have >> been optimized out, but the current fsign implementation would emit >> bogus IR if abs was set for the argument (because it would apply the >> abs modif

Re: [Mesa-dev] [PATCH 4/8] i965/fs: Fix nir_op_fsign of absolute value.

2017-01-24 Thread Ian Romanick
On 01/24/2017 03:26 PM, Francisco Jerez wrote: > This does point at the front-end emitting silly code that could have > been optimized out, but the current fsign implementation would emit > bogus IR if abs was set for the argument (because it would apply the > abs modifier on an unsigned integer ty

[Mesa-dev] [PATCH 4/8] i965/fs: Fix nir_op_fsign of absolute value.

2017-01-24 Thread Francisco Jerez
This does point at the front-end emitting silly code that could have been optimized out, but the current fsign implementation would emit bogus IR if abs was set for the argument (because it would apply the abs modifier on an unsigned integer type), and we shouldn't rely on the upper layer's optimiz