Re: [Mesa-dev] [PATCH 4/6] glsl: fully split apart buffer block arrays

2016-04-05 Thread Timothy Arceri
On Tue, 2016-04-05 at 12:05 +0200, Samuel Iglesias Gonsálvez wrote: > In general, I don't see anything wrong with this series, just minor > things in this patch. > > Once they are fixed and if piglit/dEQP don't complain, add my R-b to > this series: > > Reviewed-by: Samuel Iglesias Gonsálvez >

Re: [Mesa-dev] [PATCH 4/6] glsl: fully split apart buffer block arrays

2016-04-05 Thread Samuel Iglesias Gonsálvez
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 In general, I don't see anything wrong with this series, just minor things in this patch. Once they are fixed and if piglit/dEQP don't complain, add my R-b to this series: Reviewed-by: Samuel Iglesias Gonsálvez On 03/04/16 13:16, Timothy Arceri w

[Mesa-dev] [PATCH 4/6] glsl: fully split apart buffer block arrays

2016-04-03 Thread Timothy Arceri
With this chage we create the UBO and SSBO arrays separately from the beginning rather than putting them into a combined array and splitting it apart later. --- src/compiler/glsl/link_uniform_blocks.cpp | 204 +--- src/compiler/glsl/link_uniform_initializers.cpp | 4 +-