Re: [Mesa-dev] [PATCH 4/5] radv: Always set disable zpass increment bit when possible.

2018-07-17 Thread Samuel Pitoiset
Assuming this doesn't break anything, patch is: Reviewed-by: Samuel Pitoiset On 07/17/2018 11:06 AM, Bas Nieuwenhuizen wrote: Aligning with AMDVLK on GFX9. I don't think it changes much. On Tue, Jul 17, 2018 at 9:15 AM, Samuel Pitoiset wrote: Why do we need that? Are you sure it's correct?

Re: [Mesa-dev] [PATCH 4/5] radv: Always set disable zpass increment bit when possible.

2018-07-17 Thread Bas Nieuwenhuizen
Aligning with AMDVLK on GFX9. I don't think it changes much. On Tue, Jul 17, 2018 at 9:15 AM, Samuel Pitoiset wrote: > Why do we need that? Are you sure it's correct? > > > On 07/14/2018 02:28 PM, Bas Nieuwenhuizen wrote: >> >> When no occlusion queries are active even if out of order is enabled.

Re: [Mesa-dev] [PATCH 4/5] radv: Always set disable zpass increment bit when possible.

2018-07-17 Thread Samuel Pitoiset
Why do we need that? Are you sure it's correct? On 07/14/2018 02:28 PM, Bas Nieuwenhuizen wrote: When no occlusion queries are active even if out of order is enabled. --- src/amd/vulkan/radv_cmd_buffer.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/amd/vulkan/rad

[Mesa-dev] [PATCH 4/5] radv: Always set disable zpass increment bit when possible.

2018-07-14 Thread Bas Nieuwenhuizen
When no occlusion queries are active even if out of order is enabled. --- src/amd/vulkan/radv_cmd_buffer.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index b6729e40b4..78838d9939 100644 --- a/src/amd/vu