Re: [Mesa-dev] [PATCH 4/5] glsl: Implement MESA_shader_integer_mix extension.

2013-09-09 Thread Ian Romanick
Two tiny edits, that just occurred to me, are below... On 09/06/2013 07:57 PM, Matt Turner wrote: > Because why doesn't GLSL allow you to do this already? > --- > docs/specs/MESA_shader_integer_mix.spec | 125 > > src/glsl/builtin_functions.cpp | 15 +++

Re: [Mesa-dev] [PATCH 4/5] glsl: Implement MESA_shader_integer_mix extension.

2013-09-07 Thread Matt Turner
On Fri, Sep 6, 2013 at 10:53 PM, Kenneth Graunke wrote: >> +2) Should we mix() to select between boolean components? > > > I feel like there should be a word between "Should we" and "mix()". Perhaps > "Should we allow mix() to select between boolean components"? Yes, definitely missing a word

Re: [Mesa-dev] [PATCH 4/5] glsl: Implement MESA_shader_integer_mix extension.

2013-09-06 Thread Kenneth Graunke
On 09/06/2013 05:57 PM, Matt Turner wrote: Because why doesn't GLSL allow you to do this already? --- docs/specs/MESA_shader_integer_mix.spec | 125 src/glsl/builtin_functions.cpp | 15 src/glsl/glcpp/glcpp-parse.y| 3 + src/glsl/

[Mesa-dev] [PATCH 4/5] glsl: Implement MESA_shader_integer_mix extension.

2013-09-06 Thread Matt Turner
Because why doesn't GLSL allow you to do this already? --- docs/specs/MESA_shader_integer_mix.spec | 125 src/glsl/builtin_functions.cpp | 15 src/glsl/glcpp/glcpp-parse.y| 3 + src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/