[Mesa-dev] [PATCH 4/5] glsl: Fix conversions in array constructors

2011-07-29 Thread Chad Versace
Array constructors obey narrower conversion rules than other constructors [1] --- they use the implicit conversion rules [2] instead of the scalar constructor conversions [3]. But process_array_constructor() was incorrectly applying the broader rules. [1] GLSL 1.50 spec, Section 5.4.4 Array Const

Re: [Mesa-dev] [PATCH 4/5] glsl: Fix conversions in array constructors

2011-07-29 Thread Chad Versace
On 07/29/2011 01:57 PM, Kenneth Graunke wrote: > On 07/27/2011 10:55 PM, Chad Versace wrote: >> Array constructors obey narrower conversion rules than other constructors >> [1] --- they use the implicit conversion rules [2] instead of the scalar >> constructor conversions [3]. But process_array_co

Re: [Mesa-dev] [PATCH 4/5] glsl: Fix conversions in array constructors

2011-07-29 Thread Kenneth Graunke
On 07/27/2011 10:55 PM, Chad Versace wrote: > Array constructors obey narrower conversion rules than other constructors > [1] --- they use the implicit conversion rules [2] instead of the scalar > constructor conversions [3]. But process_array_constructor() was > incorrectly applying the broader r

[Mesa-dev] [PATCH 4/5] glsl: Fix conversions in array constructors

2011-07-27 Thread Chad Versace
Array constructors obey narrower conversion rules than other constructors [1] --- they use the implicit conversion rules [2] instead of the scalar constructor conversions [3]. But process_array_constructor() was incorrectly applying the broader rules. To fix this, first check (with glsl_type::can