Re: [Mesa-dev] [PATCH 4/4] vbo: fix VBO optimization regression

2018-01-18 Thread Brian Paul
I just pushed it and updated https://bugs.freedesktop.org/show_bug.cgi?id=104690 -Brian On 01/18/2018 03:10 PM, Ian Romanick wrote: Mark: Can you check that this fixes the G33 regression that you mentioned to me this morning? On 01/17/2018 02:57 PM, Brian Paul wrote: The optimization in chan

Re: [Mesa-dev] [PATCH 4/4] vbo: fix VBO optimization regression

2018-01-18 Thread Ian Romanick
Mark: Can you check that this fixes the G33 regression that you mentioned to me this morning? On 01/17/2018 02:57 PM, Brian Paul wrote: > The optimization in change 8e4efdc895ea ("vbo: optimize some display > list drawing") missed the loopback case. This is used when the > glBegin/End primitive d

[Mesa-dev] [PATCH 4/4] vbo: fix VBO optimization regression

2018-01-18 Thread Brian Paul
The optimization in change 8e4efdc895ea ("vbo: optimize some display list drawing") missed the loopback case. This is used when the glBegin/End primitive doesn't have a uniform set of vertex attributes. The new Piglit gl-1.0-dlist-materials test hits this. So check the aligned_vertex_buffer_offse

Re: [Mesa-dev] [PATCH 4/4] vbo: fix VBO optimization regression

2018-01-18 Thread Roland Scheidegger
Looks alright to me. Reviewed-by: Roland Scheidegger Am 17.01.2018 um 23:57 schrieb Brian Paul: > The optimization in change 8e4efdc895ea ("vbo: optimize some display > list drawing") missed the loopback case. This is used when the > glBegin/End primitive doesn't have a uniform set of vertex at