Re: [Mesa-dev] [PATCH 4/4] nir: link time opt duplicate varyings

On Mon, Dec 10, 2018 at 10:28 PM Timothy Arceri wrote: > If we are outputting the same value to more than one output > component rewrite the inputs to read from a single component. > > This will allow the duplicate varying components to be optimised > away by the existing opts. > > shader-db resu

Re: [Mesa-dev] [PATCH 4/4] nir: link time opt duplicate varyings

On Fri, Dec 14, 2018 at 9:16 PM Timothy Arceri wrote: > On 15/12/18 7:32 am, Marek Olšák wrote: > > For patches 1-3: > > > > Reviewed-by: Marek Olšák marek.ol...@amd.com>> > > > > Thanks! > > > I'm not so knowledgeable to be able to comment on patch 4. > > > > Does it also merge varyings such as

Re: [Mesa-dev] [PATCH 4/4] nir: link time opt duplicate varyings

On 15/12/18 1:16 pm, Timothy Arceri wrote: On 15/12/18 7:32 am, Marek Olšák wrote: For patches 1-3: Reviewed-by: Marek Olšák > Thanks! I'm not so knowledgeable to be able to comment on patch 4. Does it also merge varyings such as (x,y,undef,undef) and (x,unde

Re: [Mesa-dev] [PATCH 4/4] nir: link time opt duplicate varyings

On 15/12/18 7:32 am, Marek Olšák wrote: For patches 1-3: Reviewed-by: Marek Olšák mailto:marek.ol...@amd.com>> Thanks! I'm not so knowledgeable to be able to comment on patch 4. Does it also merge varyings such as (x,y,undef,undef) and (x,undef,undef,w)? There is a game which outputs (x,y

Re: [Mesa-dev] [PATCH 4/4] nir: link time opt duplicate varyings

For patches 1-3: Reviewed-by: Marek Olšák I'm not so knowledgeable to be able to comment on patch 4. Does it also merge varyings such as (x,y,undef,undef) and (x,undef,undef,w)? There is a game which outputs (x,y,z,undef) and (x,y,undef,undef) where the vertex shader is a SSO. Marek On Mon, D

[Mesa-dev] [PATCH 4/4] nir: link time opt duplicate varyings

If we are outputting the same value to more than one output component rewrite the inputs to read from a single component. This will allow the duplicate varying components to be optimised away by the existing opts. shader-db results i965 (SKL): total instructions in shared programs: 12869230 -> 1