Re: [Mesa-dev] [PATCH 4/4] nir: detect more induction variables

2018-11-30 Thread Thomas Helland
I've done a couple passes over the patches now. Neatly implemented and look correct to me. With the two small nitpicks below correct this whole series is: Reviewed-by: Thomas Helland Den ons. 28. nov. 2018 kl. 04:26 skrev Timothy Arceri : > > This adds allows loop analysis to detect inductions v

Re: [Mesa-dev] [PATCH 4/4] nir: detect more induction variables

2018-11-30 Thread Ian Romanick
On 11/29/2018 10:38 PM, Thomas Helland wrote: > Den ons. 28. nov. 2018 kl. 10:23 skrev Timothy Arceri : >> >> On 28/11/18 6:52 pm, Thomas Helland wrote: >>> Den ons. 28. nov. 2018 kl. 04:26 skrev Timothy Arceri >>> : This adds allows loop analysis to detect inductions varibales that

Re: [Mesa-dev] [PATCH 4/4] nir: detect more induction variables

2018-11-30 Thread Timothy Arceri
On 30/11/18 5:38 pm, Thomas Helland wrote: Den ons. 28. nov. 2018 kl. 10:23 skrev Timothy Arceri : On 28/11/18 6:52 pm, Thomas Helland wrote: Den ons. 28. nov. 2018 kl. 04:26 skrev Timothy Arceri : This adds allows loop analysis to detect inductions varibales that are incremented in both bra

Re: [Mesa-dev] [PATCH 4/4] nir: detect more induction variables

2018-11-29 Thread Thomas Helland
Den ons. 28. nov. 2018 kl. 10:23 skrev Timothy Arceri : > > On 28/11/18 6:52 pm, Thomas Helland wrote: > > Den ons. 28. nov. 2018 kl. 04:26 skrev Timothy Arceri > > : > >> > >> This adds allows loop analysis to detect inductions varibales that > >> are incremented in both branches of an if rather

Re: [Mesa-dev] [PATCH 4/4] nir: detect more induction variables

2018-11-28 Thread Eero Tamminen
Hi, On 28.11.2018 5.25, Timothy Arceri wrote: This adds allows loop analysis to detect inductions varibales that are incremented in both branches of an if rather than in a main loop block. For example: [...]> Unfortunatly GCM could move the addition out of the if for us (making this patch unre

Re: [Mesa-dev] [PATCH 4/4] nir: detect more induction variables

2018-11-28 Thread Timothy Arceri
On 28/11/18 6:52 pm, Thomas Helland wrote: Den ons. 28. nov. 2018 kl. 04:26 skrev Timothy Arceri : This adds allows loop analysis to detect inductions varibales that are incremented in both branches of an if rather than in a main loop block. For example: loop { block block_1:

Re: [Mesa-dev] [PATCH 4/4] nir: detect more induction variables

2018-11-27 Thread Thomas Helland
Den ons. 28. nov. 2018 kl. 04:26 skrev Timothy Arceri : > > This adds allows loop analysis to detect inductions varibales that > are incremented in both branches of an if rather than in a main > loop block. For example: > >loop { > block block_1: > /* preds: block_0 block_7 */ >

[Mesa-dev] [PATCH 4/4] nir: detect more induction variables

2018-11-27 Thread Timothy Arceri
This adds allows loop analysis to detect inductions varibales that are incremented in both branches of an if rather than in a main loop block. For example: loop { block block_1: /* preds: block_0 block_7 */ vec1 32 ssa_8 = phi block_0: ssa_4, block_7: ssa_20 vec1 32 ssa_