Re: [Mesa-dev] [PATCH 4/4] mesa: fix validate for secondary interpolator

2017-11-27 Thread Ian Romanick
On 11/21/2017 04:22 PM, Miklós Máté wrote: > On 21/11/17 02:09, Ian Romanick wrote: >> On 11/20/2017 04:07 PM, Miklós Máté wrote: >>> This patch fixes multiple problems: >>> - the interpolator check was duplicated >>> - both had arg instead of argRep >>> - I split it into color and alpha for better

Re: [Mesa-dev] [PATCH 4/4] mesa: fix validate for secondary interpolator

2017-11-21 Thread Miklós Máté
On 21/11/17 02:09, Ian Romanick wrote: On 11/20/2017 04:07 PM, Miklós Máté wrote: This patch fixes multiple problems: - the interpolator check was duplicated - both had arg instead of argRep - I split it into color and alpha for better readability and error msg - the DOT4 check only applies to c

Re: [Mesa-dev] [PATCH 4/4] mesa: fix validate for secondary interpolator

2017-11-20 Thread Ian Romanick
On 11/20/2017 04:07 PM, Miklós Máté wrote: > This patch fixes multiple problems: > - the interpolator check was duplicated > - both had arg instead of argRep > - I split it into color and alpha for better readability and error msg > - the DOT4 check only applies to color instruction according to th

[Mesa-dev] [PATCH 4/4] mesa: fix validate for secondary interpolator

2017-11-20 Thread Miklós Máté
This patch fixes multiple problems: - the interpolator check was duplicated - both had arg instead of argRep - I split it into color and alpha for better readability and error msg - the DOT4 check only applies to color instruction according to the spec - made the DOT4 check fatal, and improved the