Re: [Mesa-dev] [PATCH 4/4] mesa: Implement glGetFragDataLocation

2011-11-09 Thread Kenneth Graunke
On 11/09/2011 02:20 PM, Ian Romanick wrote: You mean, drop the 'var->location < FRAG_RESULT_DATA0' from the if-statement below? That is probably true. It was a copy-and-paste from GetAttributeLocation. The check *is* necessary there because there is no 'strncmp("gl_", name)' in that function. Get

Re: [Mesa-dev] [PATCH 4/4] mesa: Implement glGetFragDataLocation

2011-11-09 Thread Ian Romanick
On 11/08/2011 08:16 PM, Kenneth Graunke wrote: On 11/08/2011 08:10 PM, Kenneth Graunke wrote: On 11/04/2011 04:41 PM, Ian Romanick wrote: From: Ian Romanick Fixes piglit's getfragdatalocation test. Signed-off-by: Ian Romanick --- src/mesa/main/shader_query.cpp | 56 +++

Re: [Mesa-dev] [PATCH 4/4] mesa: Implement glGetFragDataLocation

2011-11-08 Thread Kenneth Graunke
On 11/08/2011 08:10 PM, Kenneth Graunke wrote: > On 11/04/2011 04:41 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Fixes piglit's getfragdatalocation test. >> >> Signed-off-by: Ian Romanick >> --- >> src/mesa/main/shader_query.cpp | 56 >> >> src

Re: [Mesa-dev] [PATCH 4/4] mesa: Implement glGetFragDataLocation

2011-11-08 Thread Kenneth Graunke
On 11/04/2011 04:41 PM, Ian Romanick wrote: > From: Ian Romanick > > Fixes piglit's getfragdatalocation test. > > Signed-off-by: Ian Romanick > --- > src/mesa/main/shader_query.cpp | 56 > > src/mesa/main/shaderapi.c | 20 -- > 2 f

Re: [Mesa-dev] [PATCH 4/4] mesa: Implement glGetFragDataLocation

2011-11-07 Thread Eric Anholt
On Fri, 4 Nov 2011 16:41:00 -0700, "Ian Romanick" wrote: > From: Ian Romanick > > Fixes piglit's getfragdatalocation test. > > Signed-off-by: Ian Romanick I think patch 2/4 and 3/4 should be squashed -- if you're looking at an issue in either one, you would want to be reading the two of them

[Mesa-dev] [PATCH 4/4] mesa: Implement glGetFragDataLocation

2011-11-04 Thread Ian Romanick
From: Ian Romanick Fixes piglit's getfragdatalocation test. Signed-off-by: Ian Romanick --- src/mesa/main/shader_query.cpp | 56 src/mesa/main/shaderapi.c | 20 -- 2 files changed, 56 insertions(+), 20 deletions(-) diff --git a/src