Re: [Mesa-dev] [PATCH 4/4] i965/vec4: Make src_reg immediate constructors explicit.

2014-11-13 Thread Francisco Jerez
Kenneth Graunke writes: > We did this for fs_reg a while back, and it's generally a good idea. > I disagree, explicit constructors aren't a one-size-fits-all. IMO there are three scenarios in which explicit constructors may be a good idea: - Cases where your constructor may lose relevant infor

[Mesa-dev] [PATCH 4/4] i965/vec4: Make src_reg immediate constructors explicit.

2014-11-12 Thread Kenneth Graunke
We did this for fs_reg a while back, and it's generally a good idea. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_vec4.h | 6 +-- src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 35 --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp| 12 ++---