Re: [Mesa-dev] [PATCH 4/4] Fix build with gcc 3.3.

2010-04-19 Thread Brian Paul
Owain Ainsworth wrote: On Mon, Apr 19, 2010 at 07:34:04AM +0200, Matthieu Herrb wrote: On Sun, Apr 18, 2010 at 05:03:51PM -0700, Jeremy Huddleston wrote: This one looks broken... #if defined(__GNUC__) && ((__GNUC__ == 3 && __GNUC__ >= 4) || __GNUC__ >= 4) (__GNUC__ == 3 && __GNUC__ >= 4) y

Re: [Mesa-dev] [PATCH 4/4] Fix build with gcc 3.3.

2010-04-19 Thread Matthieu Herrb
On Sun, Apr 18, 2010 at 05:03:51PM -0700, Jeremy Huddleston wrote: > This one looks broken... > > > #if defined(__GNUC__) && ((__GNUC__ == 3 && __GNUC__ >= 4) || __GNUC__ >= 4) > > > (__GNUC__ == 3 && __GNUC__ >= 4) > > you forgot _MINOR... > > And I think your '__GNUC_MINOR__ >= 3' might need

Re: [Mesa-dev] [PATCH 4/4] Fix build with gcc 3.3.

2010-04-18 Thread Owain Ainsworth
On Mon, Apr 19, 2010 at 07:34:04AM +0200, Matthieu Herrb wrote: > On Sun, Apr 18, 2010 at 05:03:51PM -0700, Jeremy Huddleston wrote: > > This one looks broken... > > > > > #if defined(__GNUC__) && ((__GNUC__ == 3 && __GNUC__ >= 4) || __GNUC__ >= > > > 4) > > > > > > (__GNUC__ == 3 && __GNUC__ >

Re: [Mesa-dev] [PATCH 4/4] Fix build with gcc 3.3.

2010-04-18 Thread Jeremy Huddleston
This one looks broken... > #if defined(__GNUC__) && ((__GNUC__ == 3 && __GNUC__ >= 4) || __GNUC__ >= 4) (__GNUC__ == 3 && __GNUC__ >= 4) you forgot _MINOR... And I think your '__GNUC_MINOR__ >= 3' might need to be >= 4 On Apr 18, 2010, at 16:55, Owain G. Ainsworth wrote: > From: Matthieu Her

[Mesa-dev] [PATCH 4/4] Fix build with gcc 3.3.

2010-04-18 Thread Owain G. Ainsworth
From: Matthieu Herrb The builtins used here only appeard in gcc 3.4. --- src/mesa/main/imports.c |3 ++- src/mesa/main/imports.h |4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/imports.c b/src/mesa/main/imports.c index 1ae0853..65fd476 100644 --- a/s