Re: [Mesa-dev] [PATCH 32/59] intel/compiler: fix 16-bit float ddx and ddy for SIMD8

2018-12-11 Thread Iago Toral
I used byte_offset() in the previous patch like you suggested and with that we no longer need this one. On Fri, 2018-12-07 at 13:09 -0600, Jason Ekstrand wrote: > And here we are I think I'd still like byte_offset better but, > either way patches 31 and 32 are > > Reviewed-by: Jason Ekstrand

Re: [Mesa-dev] [PATCH 32/59] intel/compiler: fix 16-bit float ddx and ddy for SIMD8

2018-12-07 Thread Jason Ekstrand
And here we are I think I'd still like byte_offset better but, either way patches 31 and 32 are Reviewed-by: Jason Ekstrand On Tue, Dec 4, 2018 at 1:18 AM Iago Toral Quiroga wrote: > In SIMD8 we pack 2 vector components in a single SIMD register, so > for example, component Y of a 16-bit v

[Mesa-dev] [PATCH 32/59] intel/compiler: fix 16-bit float ddx and ddy for SIMD8

2018-12-03 Thread Iago Toral Quiroga
In SIMD8 we pack 2 vector components in a single SIMD register, so for example, component Y of a 16-bit vec2 starts is at byte offset 16B. This means that when we compute the offset of the elements to be differentiated we should not stomp whatever base offset we have, but instead add to it. --- sr