Re: [Mesa-dev] [PATCH 3/9] i965/nir: Lower to registers a bit later.

2015-03-11 Thread Ian Romanick
On 03/11/2015 12:01 PM, Kenneth Graunke wrote: > On Wednesday, March 11, 2015 10:29:02 AM Ian Romanick wrote: >> On 03/09/2015 01:58 AM, Kenneth Graunke wrote: >>> We can't safely call nir_optimize() with register present, since several >>> passes called in the loop can't handle registers, and will

Re: [Mesa-dev] [PATCH 3/9] i965/nir: Lower to registers a bit later.

2015-03-11 Thread Kenneth Graunke
On Wednesday, March 11, 2015 10:29:02 AM Ian Romanick wrote: > On 03/09/2015 01:58 AM, Kenneth Graunke wrote: > > We can't safely call nir_optimize() with register present, since several > > passes called in the loop can't handle registers, and will fail asserts. > > Doesn't that mean this patch s

Re: [Mesa-dev] [PATCH 3/9] i965/nir: Lower to registers a bit later.

2015-03-11 Thread Ian Romanick
On 03/09/2015 01:58 AM, Kenneth Graunke wrote: > We can't safely call nir_optimize() with register present, since several > passes called in the loop can't handle registers, and will fail asserts. Doesn't that mean this patch should go before patch 2? > Notably, nir_lower_vec_alus() and nir_opt_a

[Mesa-dev] [PATCH 3/9] i965/nir: Lower to registers a bit later.

2015-03-09 Thread Kenneth Graunke
We can't safely call nir_optimize() with register present, since several passes called in the loop can't handle registers, and will fail asserts. Notably, nir_lower_vec_alus() and nir_opt_algebraic() really don't want registers. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_f