Re: [Mesa-dev] [PATCH 3/8] i965: Expand comments in brw_upload_indices().

2014-03-15 Thread Kenneth Graunke
On 03/13/2014 08:59 AM, Ian Romanick wrote: > On 03/13/2014 01:57 AM, Kenneth Graunke wrote: >> This function has three cases: >> 1. Data is in user arrays >> 2. Data is in a buffer object, but misaligned. >> 3. Data is acceptable as is. >> >> Previously, there was a "Turn into a proper VBO" commen

Re: [Mesa-dev] [PATCH 3/8] i965: Expand comments in brw_upload_indices().

2014-03-13 Thread Ian Romanick
On 03/13/2014 01:57 AM, Kenneth Graunke wrote: > This function has three cases: > 1. Data is in user arrays > 2. Data is in a buffer object, but misaligned. > 3. Data is acceptable as is. > > Previously, there was a "Turn into a proper VBO" comment above all three > cases, even though it only appl

[Mesa-dev] [PATCH 3/8] i965: Expand comments in brw_upload_indices().

2014-03-13 Thread Kenneth Graunke
This function has three cases: 1. Data is in user arrays 2. Data is in a buffer object, but misaligned. 3. Data is acceptable as is. Previously, there was a "Turn into a proper VBO" comment above all three cases, even though it only applies to case 1, and maybe case 2 (with a specific interpretati