Re: [Mesa-dev] [PATCH 3/8] glsl: Rework lowering of non-constant array indexing

2011-07-20 Thread Eric Anholt
On Mon, 18 Jul 2011 14:15:22 -0700, "Ian Romanick" wrote: > From: Ian Romanick > > The previous implementation could easily get tricked if the LHS of an > assignment included a non-constant index that was "inside" another > dereference. For example: > > mat4 m[2]; > m[0][i] = vec4(0.0)

[Mesa-dev] [PATCH 3/8] glsl: Rework lowering of non-constant array indexing

2011-07-18 Thread Ian Romanick
From: Ian Romanick The previous implementation could easily get tricked if the LHS of an assignment included a non-constant index that was "inside" another dereference. For example: mat4 m[2]; m[0][i] = vec4(0.0); Due to the way it tracked whether the array was being assigned, it would